This repository has been archived by the owner on Mar 15, 2022. It is now read-only.
Add makeCall wrapper #457
Merged
Add makeCall wrapper #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ReaderAlignType Alignment = Reader_AlignUnknown, | ||
| bool IsVolatile = false, bool NoCtor = false, | ||
| bool CanMoveUp = false); | ||
| llvm::CallSite callHelperImpl(CorInfoHelpFunc HelperID, bool MayThrow, |
There was a problem hiding this comment.
Not something that you have to change now, but it might be nice if this method took an ArrayRef<Value*> instead of the optional IRNode parameters.
|
LGTM. |
JosephTremoulet
force-pushed
the
MakeCall
branch
from
5d59981 to
7cc5356
Compare
This wraps LLVMBuilder->CreateCall, and will be where the logic goes that instead creates an invoke with an appropriate exception edge if we're in a protected region.
JosephTremoulet
force-pushed
the
MakeCall
branch
from
7cc5356 to
9369fba
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps LLVMBuilder->CreateCall, and will be where the logic goes that
instead creates an invoke with an appropriate exception edge if we're in a
protected region.
I decided to go ahead and split this out from my EH changes and PR it to master since it touches many lines and I expect this aspect of the changes (having a makeCall helper with this signature) to stick.